Merged
Conversation
… the start — no waiting for PROCREP. But we still wait for SYSREP before we convert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our clock conversion was getting poisoned with a bad state when the cbsdk session was initialized for NPLAY when connected to a legacy NPLAY session. This is because Legacy nPlay uses clock ticks, not nanoseconds, but there is no way for us to know that until we get a PROCREP packet near the beginning of the response to REQCONFIGALL.
This fix resets the clock sync state after that packet is received and we determine that we are non-gemini (i.e., non nanosecond timestamps).